Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon ticks a running workflow multiple times #279

Closed
aiida-bot opened this issue Oct 10, 2016 · 3 comments
Closed

Daemon ticks a running workflow multiple times #279

aiida-bot opened this issue Oct 10, 2016 · 3 comments
Assignees
Milestone

Comments

@aiida-bot
Copy link

Originally reported by: Martin Uhrin (Bitbucket: muhrin, GitHub: muhrin)


If you, say, call run(...) in a workflow to launch a remote calculation this call will block until complete. In the meantime the daemon will tick the workflow engine again and perform the first step, relaunching the calculation. This should no happen.

In general we need a blocking mechanism to deal with workflows that are currently being executed so they aren't ran twice.

Even more generally we should probably move to a work queue model (instead of the polling model) which would more cleanly sort out issues like this one.


@broeder-j
Copy link
Member

@muhrin, I think this is all solved, or is this still open because of the 'work queue model'?

@muhrin
Copy link
Contributor

muhrin commented Jan 25, 2018

This is fixed both in the released 0.11.0 as well as in the current workflows branch which contains the new workflow engine, which will be merged into develop soon for 0.12.0

@muhrin muhrin closed this as completed Jan 25, 2018
@sphuber sphuber added this to the v0.12.0 milestone Jan 25, 2018
@sphuber
Copy link
Contributor

sphuber commented May 2, 2018

No longer relevant due to merge #1468

@sphuber sphuber reopened this May 2, 2018
@sphuber sphuber closed this as completed May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants