Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Consider using CircleCI for documentation CI #4028

Closed
chrisjsewell opened this issue May 1, 2020 · 3 comments
Closed

Docs: Consider using CircleCI for documentation CI #4028

chrisjsewell opened this issue May 1, 2020 · 3 comments

Comments

@chrisjsewell
Copy link
Member

chrisjsewell commented May 1, 2020

One thing that I wanted to briefly mention, although it is most probably not something I expect us to implement, is that currently using CircleCI for documentation integration testing has a big benefit over GitHub Actions, because it can provide HTML build artefacts. For example in: executablebooks/sphinx-panels#3, you get a link that directly opens the newly built documentation for review:

image

I'm wondering whether it would be possible to implement something similar in GitHub actions as well though

Unfortunately at the moment no. I would refer you to this issue, roughly tracking the status of this feature in Github actions: spatialaudio/nbsphinx#361

Originally posted by @chrisjsewell in #4011 (comment)

@sphuber sphuber changed the title DOCS: Consider using CircleCI for documentation CI Docs: Consider using CircleCI for documentation CI May 2, 2020
@csadorf csadorf added this to the Publish revised documentation milestone May 6, 2020
@csadorf csadorf removed this from the Publish revised documentation milestone May 15, 2020
@sphuber
Copy link
Contributor

sphuber commented May 25, 2020

Fixed in PR #4099

@sphuber
Copy link
Contributor

sphuber commented May 30, 2020

Just as an update: the upload-artifact action now supports uploading an entire directory (as of v2), without zipping it, which was the original behavior. This would make it possible to switch back to GHA from CircleCI, where it not for the fact that the GUI currently does not allow to view the files in the browser. So it still doesn't solve our use case. However, support for that is also being worked on

@chrisjsewell
Copy link
Member Author

Thanks for the update @sphuber, FYI I opened a separate issue for moving back #4104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@csadorf @chrisjsewell @ramirezfranciscof @sphuber and others