Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setting of CalcJob specific inputs from Process base class #5537

Closed
sphuber opened this issue May 23, 2022 · 0 comments · Fixed by #5539
Closed

Remove setting of CalcJob specific inputs from Process base class #5537

sphuber opened this issue May 23, 2022 · 0 comments · Fixed by #5539
Assignees
@sphuber
Labels
priority/quality-of-life would simplify development topic/calc-jobs topic/processes type/refactoring
Milestone
v2.1.0

Comments

@sphuber
Copy link
Contributor

sphuber commented May 23, 2022

Implementation details of the CalcJob are implemented directly in the Process base class. Specifically, the metadata.options and metadata.computer are dealt with in _setup_metadata. Also _setup_inputs is guilty of this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

Labels
priority/quality-of-life would simplify development topic/calc-jobs topic/processes type/refactoring
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

Process: refactor out input handling specific to CalcJob sphuber/aiida-core
1 participant
@sphuber