Tests: Fix tests.orm.nodes.test_node:test_delete_through_backend
#6496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing with a `core.sqlite_dos` storage plugin for the test profile. The problem is that the last assert was checking that the logs for `data_two` were deleted because `data_two` itself had been deleted. However, since it was deleted, the ORM instance can no longer be used either, which was causing an exception. Instead, its pk should be recorded before deleting the node, and the final check should just use the pk directly. It is not quite clear why this test was not failing for the default `core.psql_dos` storage plugin that is used for tests. It should not be backend specific since both use SQLAlchemy for the ORM.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6496 +/- ##
==========================================
+ Coverage 77.51% 77.79% +0.29%
==========================================
Files 560 561 +1
Lines 41444 41809 +365
==========================================
+ Hits 32120 32522 +402
+ Misses 9324 9287 -37 ☔ View full report in Codecov by Sentry. |
mikibonacci
pushed a commit
to mikibonacci/aiida-core
that referenced
this pull request
Sep 3, 2024
…iidateam#6496) The test was failing with a `core.sqlite_dos` storage plugin for the test profile. The problem is that the last assert was checking that the logs for `data_two` were deleted because `data_two` itself had been deleted. However, since it was deleted, the ORM instance can no longer be used either, which was causing an exception. Instead, its pk should be recorded before deleting the node, and the final check should just use the pk directly. It is not quite clear why this test was not failing for the default `core.psql_dos` storage plugin that is used for tests. It should not be backend specific since both use SQLAlchemy for the ORM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6436
The test was failing with a
core.sqlite_dosstorage plugin for the test profile. The problem is that the last assert was checking that the logs fordata_twowere deleted becausedata_twoitself had been deleted. However, since it was deleted, the ORM instance can no longer be used either, which was causing an exception. Instead, its pk should be recorded before deleting the node, and the final check should just use the pk directly.It is not quite clear why this test was not failing for the default
core.psql_dosstorage plugin that is used for tests. It should not be backend specific since both use SQLAlchemy for the ORM.