Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to aiida.orm.utils.remote #6503

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

danielhollas
Copy link
Collaborator

No description provided.

@danielhollas danielhollas changed the title WIP: Add types to aiida.orm.utils Add types to aiida.orm.utils.{remote,node} Jul 3, 2024
This reverts commit b5fa0ce72d8a21044bd852e3b0054c69d16e55a0.
@danielhollas danielhollas changed the title Add types to aiida.orm.utils.{remote,node} Add types to aiida.orm.utils.remote Jul 14, 2024
@danielhollas danielhollas marked this pull request as ready for review July 14, 2024 22:56
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.82%. Comparing base (ef60b66) to head (2e9b4bb).
Report is 116 commits behind head on main.

Files with missing lines Patch % Lines
src/aiida/orm/utils/remote.py 63.64% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6503      +/-   ##
==========================================
+ Coverage   77.51%   77.82%   +0.32%     
==========================================
  Files         560      564       +4     
  Lines       41444    41918     +474     
==========================================
+ Hits        32120    32619     +499     
+ Misses       9324     9299      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danielhollas

@sphuber sphuber merged commit 2bdcb7f into aiidateam:main Jul 15, 2024
10 of 11 checks passed
mikibonacci pushed a commit to mikibonacci/aiida-core that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants