Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support for TCOD? #14

Open
ConradJohnston opened this issue Feb 19, 2021 · 3 comments
Open

Update support for TCOD? #14

ConradJohnston opened this issue Feb 19, 2021 · 3 comments

Comments

@ConradJohnston
Copy link
Collaborator

In the previous major version of the plugin (v1.x), a set of tools for interacting with TCOD was provided.

The previous version of the plugin was compatible with AiiDA v0.12, but has been broken since the release of AiiDA v1.x+.
In this time, I'm not aware of any complaints specifically relating to TCOD support.

The newest version of the plugin (v2.0.0) is compatible with the latest versions of AiiDA and re-adds and enhances the main features, but TCOD support has not been ported yet.

It may be the case that users relying on this functionality continued to use old, unsupported versions of AiiDA and did not raise any issues, but I'm not aware of this happening.

If anyone is interested or invested in these features, please respond here. The main points to address are:

  1. Is this interface desirable?
  2. What features are required?
@ConradJohnston
Copy link
Collaborator Author

Hi @merkys ,
Your thoughts here would be really valuable.

@merkys
Copy link
Member

merkys commented Feb 24, 2021

The code has survived a couple of refactorings, and I can no longer find the part which used to interface with the COD. Could you please point me to actual files implementing this functionality?

@ConradJohnston
Copy link
Collaborator Author

So I've dropped the legacy code because I didn't know how to test. Very happy to port to AiIDA v1+ if I can figure out what it should do.

You can browse the old files by checking out old commits or on GitHub - last version before I started porting is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants