Adventure 4.1.0 The mobile enhancement #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TrustyJAID
commented
Mar 3, 2024
•
TrustyJAID
commented
- Significantly reduce item displays so they appear more legible on mobile devices and smaller width discord screens.
- Add equip item select menu to item display menus including the backpack to more easily equip items.
- Fix rounding issue in special action button insight.
- Reduce instances of duplicated code.
- Some typing fixes.
- Include some new tinkerer responses thanks to Kiloreas on discord.
- Introduce deterministic challenges.
- Starting a new adventure sets the seed used for all random choices within an adventure. This is useful for developers debugging issues related to monster generation as we can now specify exactly the same starting situation an adventure happens in. Seed is shown on the adventure screen in the footer of embeds but can also be found via the invocation message ID (if embeds are disabled).
- Removed redundant actions list from adventure messages since they were out of order and used different verbs from the new buttons. Removed references to reactions since we use buttons now not reactions.
- Fix Heavenswheel set bonuses to be 2 and 5 not both 5 parts.
- Fix math on tinkerer forging and increase base modifier from 0.3 to 0.75.
- Update forging interface to use a select menu instead of having to type the item name.
- Significantly reduce item displays so they appear more legible on mobile devices and smaller width discord screens. - Add equip item select menu to item display menus including the backpack to more easily equip items. - Fix rounding issue in special action button insight. - Reduce instances of duplicated code. - Some typing fixes.
Make equip item menu allow multiple selections. Make adventurestats get the monster details the same way as everything else instead of calculating it itself.
Update cart to use a select menu instead of buttons.
Fix forging Change all backpack sorting and lookup to be lists of the item instead of (name, item) tuples. Why have the name when the Item object already has it? Prevent trading items to the bot, any bot.
List weapons from right to left. Should we maybe set a player preference for handedness?
Update mysets table to fit better on mobile devices
- Starting a new adventure sets the seed used for all random choices within an adventure. This is useful for developers debugging issues related to monster generation as we can now specify exactly the same starting situation an adventure happens in. Seed is shown on the adventure screen in the footer of embeds but can also be found via the invocation message ID (if embeds are disabled). - Removed redundant actions list from adventure messages since they were out of order and used different verbs from the new buttons. Removed references to reactions since we use buttons now not reactions.
… adventure between bots and ensure the same RNG across runs.
restrict min and max stats to the limits allowed by the game seed Allow the hex game seed to be used for starting adventures (it was annoying every time I had to convert to an int)
- Make forging display use the new item table
…tead of typing the item name. Prevent a potential issue selecting the same item twice without enough items owned causing a key error when trying to forge the new item.
…restructures the item creation to always have a confirmation when created
…ng to pull a range between 1 and 0 it should always be at least 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.