refactor(keymap)!: make map! macro non-recursively by default
#144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aileot
force-pushed
the
refactor-keymap-map_for_noremap
branch
from
0ff8cbb
to
0f0725c
Compare
aileot
force-pushed
the
refactor-keymap-map_for_noremap
branch
from
9db4d57
to
0b06237
Compare
Without `<Plug>` mappings in rhs (or callback function in rhs), `noremap` is generally preferable. BREAKING-CHANGE: `map!` sets keymap non-recursively by default; `map!` requires `remap` option to set recursive mapping
Reasons to deprecate them: - For users who only uses `vim.keymap.set`-format, the wrappers are simply oversupplied; some might feels them rather annoying overheads. - Users who prefer such wrappers can create their own wrappers as many as they want in their own environment. - `map!` now works as the same way as `noremap!`, which has become completely redundant.
aileot
force-pushed
the
refactor-keymap-map_for_noremap
branch
from
0b06237
to
ae2d176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map!macro set keymap non-recursively by default:<Plug>mappings in rhs,noremapis generally preferable.noremap!andmap!wrappers:noremap!is now completely redundant becausemap!has come to work as the same.vim.keymap.set-format, the wrappers are simply oversupplied; some might feels them rather annoying overheads.