Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage #224

Open
maypink opened this issue Oct 24, 2023 · 4 comments · May be fixed by #236
Open

Increase test coverage #224

maypink opened this issue Oct 24, 2023 · 4 comments · May be fixed by #236
Labels
discuss Requires or would benefit from a discussion enhancement New feature or request test Adding or fixing tests

Comments

@maypink
Copy link
Collaborator

maypink commented Oct 24, 2023

The current percent of coverage is ~74%, which is relatively small and allows to make more thoughtless and untested changes. Even though some functionality can be covered with integration tests, it is not enough, since unit tests allow to easily track all inconsistencies. Covergae with units must be increased to make GOLEM more stable. So the current files with the smallest percent of coverage can be seen here. These are mainly:

  • structural analysis
  • graph builder, some visualizations
  • bandits

image
@maypink maypink added enhancement New feature or request discuss Requires or would benefit from a discussion test Adding or fixing tests labels Oct 24, 2023
@maypink
Copy link
Collaborator Author

maypink commented Oct 24, 2023

я думаю, что структурный анализ, бандитов и мажорную часть тестов я возьму на себя, но надо будет просто при дальнейшем изменении функциональности побольше обращать внимания на покрытость тестами. при желании -- писать по ходу дела дополнительные.
@YamLyubov @kasyanovse @MorrisNein

@kasyanovse
Copy link
Collaborator

kasyanovse commented Oct 24, 2023 •
edited
Loading

Я могу взять ответственность за тесты модулей в golem/core/optimisers/genetic.

@MorrisNein
Copy link
Collaborator

На днях как раз размышлял, как покрыть тестами параметры визуализаций.

Пока что представляю себе такой подход: сгенерить заранее набор референсных визуализаций и сравнивать выходные на тестах с референсными. Пожалуй, стоит мне этим заняться.

Это, однако, не подойдёт для некоторых стохастических визуализаций. Для таких в автоматическом режиме можно только проверить наличие выхода в нужном формате, что уже делается.

@MorrisNein MorrisNein mentioned this issue Oct 24, 2023
Open
@kasyanovse kasyanovse linked a pull request Oct 31, 2023 that will close this issue
Draft
@kasyanovse kasyanovse linked a pull request Oct 31, 2023 that will close this issue
Increase test coverage #236
Draft
@kasyanovse
Copy link
Collaborator

Для уже существующей ветки создал PR #236 и добавил пару тестов.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss Requires or would benefit from a discussion enhancement New feature or request test Adding or fixing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase test coverage aimclub/GOLEM
3 participants
@kasyanovse @maypink @MorrisNein