Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage #236

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Increase test coverage #236

wants to merge 1 commit into from

Conversation

kasyanovse
Copy link
Collaborator

@kasyanovse kasyanovse added the test Adding or fixing tests label Oct 31, 2023
@kasyanovse kasyanovse linked an issue Oct 31, 2023 that may be closed by this pull request
Increase test coverage #224
Open
@pep8speaks
Copy link

Hello @kasyanovse! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 2:1: F401 'itertools.product' imported but unused
Line 40:1: E302 expected 2 blank lines, found 1

@kasyanovse kasyanovse mentioned this pull request Oct 31, 2023
Open
@kasyanovse kasyanovse changed the title Increase tests coverage Increase test coverage Oct 31, 2023
@kasyanovse kasyanovse marked this pull request as draft December 28, 2023 07:01
@nicl-nno
Copy link
Collaborator

@kasyanovse это можно ревьюить? Или уже неактуальны измения?

@kasyanovse
Copy link
Collaborator Author

@kasyanovse это можно ревьюить? Или уже неактуальны измения?

Именения актуальные. До ревью еще очень далеко. Хотя, если ишью в описании неактуален, то и этот пр не актуален.

@nicl-nno
Copy link
Collaborator

nicl-nno commented Feb 12, 2024 •
edited
Loading

Ишью актуален. Но мб какие-то из новых тестов самодостаточны и их можно влить уже? Если нет то нет.

@kasyanovse
Copy link
Collaborator Author

kasyanovse commented Feb 14, 2024 •
edited
Loading

Ишью актуален. Но мб какие-то из новых тестов самодостаточны и их можно влить уже? Если нет то нет.

Точно не помню, но должны быть самодостаточными. Можешь вливать, как посчитаешь нужным.

@nicl-nno
Copy link
Collaborator

@maypink как считаешь, вливаем (убрав закомментированное)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Adding or fixing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase test coverage
3 participants
@kasyanovse @pep8speaks @nicl-nno