Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIOHttpConnection init raises AttributeError on use_ssl with Elasticsearch>2.0.0 #196

Open
artemknd opened this issue Nov 11, 2019 · 0 comments
Open

AIOHttpConnection init raises AttributeError on use_ssl with Elasticsearch>2.0.0 #196

artemknd opened this issue Nov 11, 2019 · 0 comments

Comments

@artemknd
Copy link 

aioelasticsearch==0.5.2
elasticsearch==2.4.1

AIOHttpConnection takes use_ssl argument and passes one to the parent's __init__.

Then self.use_ssl gets used instead of use_ssl here
https://github.com/aio-libs/aioelasticsearch/blob/master/aioelasticsearch/connection.py#L52

It works for the latest elasticsearch-py versions, however, it doesn't work with >2.0.0, b/c there's no self.use_ssl = use_ssl there.

The fix is straightforward - use use_ssl directly instead of self.use_ssl.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artemknd