Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide MacOSX binary wheels. Help needed! #1181

Closed
asvetlov opened this issue Sep 16, 2016 · 15 comments
Closed

Provide MacOSX binary wheels. Help needed! #1181

asvetlov opened this issue Sep 16, 2016 · 15 comments
Labels

Comments

@asvetlov
Copy link
Member

asvetlov commented Sep 16, 2016

I'd love to publish MacOSX binary wheels on PyPI.

Current State for Deployment

Now we support wheels for Windows and Linux (using manylinux platform).

We have the following build matrix:

  • linux
    • platform
      • x86_64 (64 bit)
      • i686 (32 bit)
    • python
      • python 3.4
      • python 3.5
  • Windows
    • platform
      • win_amd64 (64 bit)
      • win32 (32 bit)
    • python
      • python 3.4
      • python 3.5

What's Required

According to cryptography MacOSX build matrix should be:

  • MacOSX
    • os version
      • 10.6
      • 10.10
    • platform
      • win_amd64 (64 bit)
      • win32 (32 bit)
    • python
      • python 3.4
      • python 3.5

Maybe MacOSX 10.6 is not important -- I can live with 10.10 only. Honestly I can live without Mac OS at all, my OS of choice is Ubuntu -- but many aiohttp users works on Macs for good or for bad.

So far so good.
I'm using travis-ci.org for building linux wheels and tarball and appveyor.com for Windows.
Deployment process is highly automated -- I just add new git tag and CIs does all dirty job.
Personally I'm very happy with deployment process.

I would add the same for MacOS.
But I have no MacOS box, this is the problem!
As far as I know Travis supports MacOS but it doesn't support python command for this configuration, no python is installed.
Ok, I've read that brew install python3 works on Travis.
I need not the latest python but exactly python 3.4 and python 3.5 installed.

Conclusion

I need a volunteer for tuning Travis build matrix.
The person doesn't need to be committer for the project.
Only committers have access writes for pushing new git tags, you know.
What I'm asking is modifying .travis.yml for running aiohttp test suite on MacOS.
Just making the suite working on MacOSX on both Python 3.4 and Python 3.5 would be perfect!
After that I could add required commands for building binary wheels and publishing them on PyPI.

Is there any volunteer?

@fafhrd91
Copy link
Member

you can ping Philipp, i'm sure we can find solution

@asvetlov
Copy link
Member Author

@philippb ping!

@zoidyzoidzoid
Copy link

zoidyzoidzoid commented Sep 16, 2016

I have a homebrew tap for Python 3.4 and Python 3.5. I'll make sure they're the latest versions of 3.4 and 3.5 tomorrow. It should be possible to use it on Travis.

https://github.com/zoidbergwill/homebrew-python

@asvetlov
Copy link
Member Author

@zoidbergwill thank you.

Most likely I don't need the latest versions but 3.4.2+ and any 3.5
What I need is a PR for travis build matrix.

Unfortunately I have no access to MacOS box and have no knowledge about homebrew usage.
I'd very appreciate if you would to update .travis.yml for passing tests on MacOS

@zoidyzoidzoid
Copy link

@asvetlov I'll happily have a look, and see how far I can get.

Using pyenv might be an option too. I'll try.

@zoidyzoidzoid
Copy link

Looking into this, it sounds like this should be possible and simple enough with Travis, borrowing some stuff from Cryptography's scripts.

I'm gonna have a look at it during PyConZA sprints this weekend.

@asvetlov
Copy link
Member Author

asvetlov commented Oct 7, 2016

Cool! Have you a nice conference!

@zoidyzoidzoid
Copy link

I've got OSX tests running on Travis CI now.

The wheels build and install for me locally, and I just need to tidy up my branch/commits a bit, then I'll make a PR.

@zoidyzoidzoid
Copy link

The tests don't pass for me on Python 3.5 on OSX, both on Travis and locally: https://travis-ci.org/zoidbergwill/aiohttp/builds/166216735

But work on older versions of OSX. :/

@asvetlov
Copy link
Member Author

asvetlov commented Oct 9, 2016

Very good!
I can cope with failed test later probably.

@zoidyzoidzoid
Copy link

Seems like it's a bit of a dice roll. Working now

@fafhrd91
Copy link
Member

fafhrd91 commented Feb 9, 2017

Will it help if we ran aiohttp on commercial Travis account?

@AraHaan
Copy link
Contributor

AraHaan commented Feb 16, 2017

hmm @zoidbergwill if you would like you can always help me with setting OSX up on my bin2c C++ project for the absolute latest gcc, g++ and clang available so that way I could make absolute use of the experimental filesystem header on that. So far it has been Erroring nonstop and sending annoying emails so with someone who knows more on OSX than me it would be great if I could get builds to work again on it.

@asvetlov
Copy link
Member Author

Could be closed because we have MacOS builds already (very slow boxes though but I hope @webknjaz will improve our toolchain)

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants