normalize_path_middleware tests failures

[fafhrd91]

code is in https://github.com/KeepSafe/aiohttp/tree/normalize-middleware-fixes
travis build https://travis-ci.org/KeepSafe/aiohttp/builds/198126584

@argaen i need you to look into this problem

[argaen]

Sure, I'll have a look at it

[fafhrd91]

it would be cool if you could look into this problem sooner. i'd like to release aiohttp 1.3, but can not without this fix

[argaen]

I'll try to have a look at it today but if not for sure tomorrow

[argaen]

Mmmm I don't know why this behavior but with the test case of //resource1//a//b, the request.path variable contains the following:

ipdb> request.path
'//a//b'

and that's why it fails. How did you fix the issue of the relative/absolute urls?

[fafhrd91]

i see. i will fix that. thanks

[socketpair]

This bug asso affects me (!)

[socketpair]

Tests have failed, but commit ended up in master. How is this possible? Is 1.3.1 considered stable release? I want to remind, that this version already landed in PIP.

[fafhrd91]

This was fixed befor 1.3.0 released

[socketpair]

Unfortunatelly, NO!. Tests are failed in 1.3.1. How can I help ?

[fafhrd91]

Submit PR or unit test.

[fafhrd91]

@socketpair i am planing to make 1.3.2 release today, could you provide unit test or PR?

[socketpair]

I have attached logs of failing tests. Please ask additional information if you need.
bug.txt

[fafhrd91]

hmm, interesting. it passes for me. check if you have latest yarl. also upgrade to 1.3.2, i added yarl requirements

[socketpair]

Is it safe to update yarl to latest version, and stay on aiohttp 1.2.0 ?

[fafhrd91]

Yes

[socketpair]

OK, I'm working in complex environment, so I will update yarl, and after that will try to re-build aiohttp with it.

[fafhrd91]

I would test before pushing to production

[fafhrd91]

Btw it doesn't matter for aiohttp 1.2, we added normalization middleware in 1.3

[socketpair]

Yes, I just wanted to update aiohttp and it did not pass tests...

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.