websockets

[vlad-dragos]

Hi,

I'm working on a personal project that uses websockets. I'm currently refactoring my app to use the new aiohttp.web API and from what I see in the source code there is a start_websocket method in the aiohttp.web.Response class. Is there any way that I can help with the development on that so it gets added? :)

[fafhrd91]

Sure! I think it is pretty strait forward. start_websocket() should accept request parameter same as start(), it should initiate websocket handshake, and return reader and writer objects. Similar to websocket examples

[fafhrd91]

https://github.com/KeepSafe/aiohttp/blob/master/examples/wssrv.py#L45

[fafhrd91]

start_websocket() is StreamResponse's method. It can return just reader object and for writing we can reuse write() and write_eof() methods @asvetlov thoughts?

[vlad-dragos]

I was thinking of passing the RequestHandler to the request and work all the magic in start_websockets. And then when you want to close the websocket we can call a close_websocket method on the request object. This way the logic remains in the handler. I'm going to make a push in a couple of hours with the code from my app ported to the library.

[fafhrd91]

passing RequestHandler is bad idea.

[vlad-dragos]

I meant passing the instance not the class :)

Sent from my iPhone

On 11 Dec 2014, at 20:37, Nikolay Kim notifications@github.com wrote:

passing RequestHandler is bad idea.

—
Reply to this email directly or view it on GitHub.

[fafhrd91]

passing request handler instance into request is bad idea

[vlad-dragos]

OK I was running some tests and I get this error:
Exception in callback <bound method _SelectorSocketTransport._read_ready of <asyncio.selector_events._SelectorSocketTransport object at 0x10e3e26a0>>() handle: Handle(<bound method _SelectorSocketTransport._read_ready of <asyncio.selector_events._SelectorSocketTransport object at 0x10e3e26a0>>, ()) Traceback (most recent call last): File "/usr/local/Cellar/python3/3.4.1_1/Frameworks/Python.framework/Versions/3.4/lib/python3.4/asyncio/events.py", line 39, in _run self._callback(*self._args) File "/usr/local/Cellar/python3/3.4.1_1/Frameworks/Python.framework/Versions/3.4/lib/python3.4/asyncio/selector_events.py", line 475, in _read_ready keep_open = self._protocol.eof_received() AttributeError: 'HandlerManager' object has no attribute 'eof_received'

Why would the the HandleManager be called in _SelectorSocketTransport?

[vlad-dragos]

I made a pull request on master.

[amirouche]

I made an quick hack to make work websockets with the high level api. Probably not the best way to go.

[fafhrd91]

@amirouche aiohttp already has websockets support, no need for external package. -1

@vlad-dragos btw what it the status?

[vlad-dragos]

@fafhrd91 the code is ready but wirh the end of the year it was a bit chaotic and I haven't had the time to do the unit test. I was planing on doing them this weekend.

[fafhrd91]

sounds good!

[fafhrd91]

websockets implemented in #220

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.