Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom 404 response #598

Closed
luhn opened this issue Oct 27, 2015 · 4 comments
Closed

Custom 404 response #598

luhn opened this issue Oct 27, 2015 · 4 comments
Labels

Comments

@luhn
Copy link
Contributor

luhn commented Oct 27, 2015

Perhaps I'm missing something, but there doesn't seem to be a way of customizing the 404 page except for writing your own router.

To clarify, I understand that you can customize manually raised 404s by using middlewares. I'm talking about a 404 triggered when the router cannot resolve a URL to a handler.

@luhn
Copy link
Contributor Author

luhn commented Oct 27, 2015

I retract this issue; I'm completely wrong on this. You can indeed use middlewares. I don't why I thought you couldn't.

@luhn luhn closed this as completed Oct 27, 2015
@luhn
Copy link
Contributor Author

luhn commented Oct 27, 2015

Although it could be good to document how to do this. Also, include simple middleware in aiohttp for handling this. Is this a contribution you'd be interested in?

@asvetlov
Copy link
Member

Yes, I'm interesting in docs contributions written by users and describing their problems.
As library author a don't always understand weak places in documentation.

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants