Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websocket interface change break existing code #1178

Closed
iceboy233 opened this issue Sep 16, 2016 · 3 comments
Closed

Websocket interface change break existing code #1178

iceboy233 opened this issue Sep 16, 2016 · 3 comments
Labels
outdated

Comments

@iceboy233
Copy link
Member

iceboy233 commented Sep 16, 2016 •
edited
Loading

Long story short

We recently noticed that aiohttp.web.MsgType was changed to aiohttp.web.WSMsgType, which break existing code, such as https://github.com/aio-libs/sockjs/blob/master/sockjs/transports/rawwebsocket.py#L39.

Your environment

aiohttp 1.0.0
@twd2
Copy link

twd2 commented Sep 16, 2016

+1

@asvetlov
Copy link
Member

Would you make a PR for sockjs for using canonical name?
I'm also ok for adding aiohttp.web.MsgType alias for aiohttp.web.WSMsgType and keeping in for 1.5 years.

@aio-libs-bot aio-libs-bot mentioned this issue Mar 27, 2019
Closed
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asvetlov @iceboy233 @twd2