Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ClientResponse.url to yarl.URL instance #1654

Closed
fafhrd91 opened this issue Feb 17, 2017 · 5 comments
Closed

Change ClientResponse.url to yarl.URL instance #1654

fafhrd91 opened this issue Feb 17, 2017 · 5 comments
Labels
Milestone

Comments

@fafhrd91
Copy link
Member

Deprecate ClientResponse.url_obj attribute

@fafhrd91 fafhrd91 added this to the 2.0 milestone Feb 17, 2017
fafhrd91 pushed a commit that referenced this issue Feb 17, 2017
@fafhrd91
Copy link
Member Author

done

fafhrd91 pushed a commit that referenced this issue Feb 17, 2017
@asvetlov
Copy link
Member

@fafhrd91 I should say again: you are running too fast in dropping deprecated code.
url_obj was introduced in aiohttp 1.1 which was released 2016-11-03
The change is 4 months only!
I suspect that many your changes suffer from similar problems.

P.S. I highly respect your contribution but please don't be so aggressive in dropping old styled API.
P.P.S. I would review the changes before next release. Have no time for it at weekend but I promise to spend a couple hours per day at least starting from next week.

@fafhrd91 fafhrd91 reopened this Feb 17, 2017
@fafhrd91
Copy link
Member Author

fafhrd91 commented Feb 17, 2017

I was careful about api compatibility. But I am bullish about url_obj, it is so ugly. Also it is not big change, just replacing resp.url with str(resp.url). We have this opportunity with 2.0, I do not know when we get another version bump. Also I don't think people read deprecation warnings

@fafhrd91
Copy link
Member Author

changed in master

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants