Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop "%O" in access logger #1673

Closed
fafhrd91 opened this issue Feb 22, 2017 · 3 comments
Closed

Drop "%O" in access logger #1673

fafhrd91 opened this issue Feb 22, 2017 · 3 comments
Labels
bug outdated
Milestone
2.1

Comments

@fafhrd91
Copy link
Member

implementation for "%O" is wrong. output_size was never designed to use as response size.

@asvetlov @kxepal
@fafhrd91
Copy link
Member Author

I will change "%O" to use same value as "%b", but we need to decide what to do with it in general

@fafhrd91 fafhrd91 added this to the 2.0 milestone Feb 22, 2017
@kxepal
Copy link
Member

kxepal commented Feb 22, 2017

I'm fine with either decision here since I didn't get the idea of these magic tokens at all (:

@fafhrd91 fafhrd91 modified the milestones: 2.1, 2.0 Feb 22, 2017
@fafhrd91 fafhrd91 changed the title Deprecate "%b" or "%O" in access logger Deprecate "%O" in access logger Mar 22, 2017
@fafhrd91 fafhrd91 changed the title Deprecate "%O" in access logger Drop "%O" in access logger Mar 22, 2017
fafhrd91 added a commit that referenced this issue Mar 22, 2017
@fafhrd91
Dropped "%O" in access logger #1673
0e99cfb
@cdunklau cdunklau mentioned this issue Oct 3, 2018
Merged
5 tasks
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug outdated
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@fafhrd91 @kxepal