Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should wsgi.py unquote path? #177

Closed
asvetlov opened this issue Nov 19, 2014 · 3 comments
Closed

Should wsgi.py unquote path? #177

asvetlov opened this issue Nov 19, 2014 · 3 comments
Labels

Comments

@asvetlov
Copy link
Member

See line https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/wsgi.py#L131
Current code produces error in gunicorn: benoitc/gunicorn#930

IIRC WSGI standard doesn't specifies path unquoting. WSGI library implementations unquotes param internally assuming environ['PATH_INFO'] is not unquoted string.

Any objections to unquote removing? @fafhrd91 ?

@fafhrd91
Copy link
Member

+1

On Wednesday, November 19, 2014, Andrew Svetlov notifications@github.com
wrote:

See line
https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/wsgi.py#L131
Current code produces error in gunicorn: benoitc/gunicorn#930
benoitc/gunicorn#930

IIRC WSGI standard doesn't specifies path unquoting. WSGI library
implementations unquotes param internally assuming environ['PATH_INFO']
is not unquoted string.

Any objections to unquote removing? @fafhrd91
https://github.com/fafhrd91 ?


Reply to this email directly or view it on GitHub
#177.

@jgehrcke
Copy link

So, according to the discussions in benoitc/gunicorn#1211 it looks like aiohttp's wsgi implementation should do path unquoting, as does Werkzeug and wsgiref.

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants