Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing a websocket from a low-level-server request fails #2024

Closed
jhrmnn opened this issue Jun 27, 2017 · 2 comments
Closed

Preparing a websocket from a low-level-server request fails #2024

jhrmnn opened this issue Jun 27, 2017 · 2 comments
Milestone

Comments

@jhrmnn
Copy link

jhrmnn commented Jun 27, 2017

A request from a low-level server does not have the app attribute, but web.WebSocketResponse.prepare() takes the event loop from BaseRequest.app.loop.

  File ".../aiohttp/web_ws.py", line 103, in _pre_start
    self._loop = request.app.loop
AttributeError: 'BaseRequest' object has no attribute 'app'

I was able to fix this by assigning a mock app to the request, which has a single loop attribute.

@asvetlov
Copy link
Member

Nice catch!
I think it should be fixed by storing a reference to loop in BaseRequest constructor.

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants