Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiohttp.client does not support HTTP redirect 308 (RFC 7538) #2114

Closed
himikof opened this issue Jul 19, 2017 · 3 comments
Closed

aiohttp.client does not support HTTP redirect 308 (RFC 7538) #2114

himikof opened this issue Jul 19, 2017 · 3 comments
Labels
Milestone

Comments

@himikof
Copy link

himikof commented Jul 19, 2017

Currently, aiohttp.client does not support recent HTTP redirect code 308 Permanent Redirect, defined in RFC 7538. It is simply a permanent version of already handled 307 redirect, or a legacy-free version of 301 redirect.

I would also argue that normalize_path_middleware default redirect class should be changed to HTTPPermanentRedirect, as it is currently very surprising that a user agent will likely retry a POST request as a GET one after receiving a 301 redirect from path normalization, but that is probably a breaking API change.
Still, supporting 308 in aiohttp.client would allow normalize_path_middleware to be used with POST requests in asyncio <-> asyncio communication by specifying redirect 308 manually.

@fafhrd91
Copy link
Member

Would you provide PR for client?

@asvetlov
Copy link
Member

Fixed by #2134

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants