Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aiohttp.wep.Application.make_handler should support pluggable AccessLogger #2315

Closed
hellysmile opened this issue Oct 11, 2017 · 2 comments
Closed

aiohttp.wep.Application.make_handler should support pluggable AccessLogger #2315

hellysmile opened this issue Oct 11, 2017 · 2 comments
Labels
outdated

Comments

@hellysmile
Copy link
Member

Long story short

There is now way to use custom aiohttp.helpers.AccessLogger for aiohttp.wep.Application.make_handler

Expected behaviour

aiohttp.wep.Application.make_handler support pluggable aiohttp.helpers.AccessLogger

Actual behaviour

aiohttp.web.Application.make_handler do not support pluggable aiohttp.helpers.AccessLogger
@hellysmile hellysmile mentioned this issue Oct 12, 2017
Merged
5 tasks
@asvetlov
Copy link
Member

Fixed by #2316

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asvetlov @hellysmile