-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3290 missing parameter 'raise_for_status' for aiohttp.request() #3303
Conversation
While the documentation mentions |
Codecov Report
@@ Coverage Diff @@
## master #3303 +/- ##
==========================================
- Coverage 98.07% 98.03% -0.04%
==========================================
Files 43 43
Lines 8001 8001
Branches 1354 1354
==========================================
- Hits 7847 7844 -3
- Misses 63 65 +2
- Partials 91 92 +1
Continue to review full report at Codecov.
|
Thanks! |
@asvetlov |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
What do these changes do?
Fix missing parameter 'raise_for_status' for aiohttp.request()
Are there changes in behavior for the user?
No notable changes
Related issue number
#3290
Backport
I think there is need for backport to 3.4, because documentaion says request() have this parameter from 3.4.
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.