Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3290 missing parameter 'raise_for_status' for aiohttp.request() #3303

Merged
merged 3 commits into from
Sep 29, 2018
Merged

Fix #3290 missing parameter 'raise_for_status' for aiohttp.request() #3303

merged 3 commits into from
Sep 29, 2018

Conversation

artslob
Copy link
Contributor

@artslob artslob commented Sep 29, 2018

What do these changes do?

Fix missing parameter 'raise_for_status' for aiohttp.request()

Are there changes in behavior for the user?

No notable changes

Related issue number

#3290

Backport

I think there is need for backport to 3.4, because documentaion says request() have this parameter from 3.4.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@asvetlov
Copy link
Member

While the documentation mentions raise_for_status the code is absent.
Adding a new parameter is a new functionality, it should land on aiohttp 3.5 only.

@codecov-io
Copy link

codecov-io commented Sep 29, 2018

Codecov Report

Merging #3303 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3303      +/-   ##
==========================================
- Coverage   98.07%   98.03%   -0.04%     
==========================================
  Files          43       43              
  Lines        8001     8001              
  Branches     1354     1354              
==========================================
- Hits         7847     7844       -3     
- Misses         63       65       +2     
- Partials       91       92       +1
Impacted Files Coverage Δ
aiohttp/tcp_helpers.py 90% <0%> (-6.67%) ⬇️
aiohttp/client_reqrep.py 97.48% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ed525...ff14d5d. Read the comment docs.

@asvetlov asvetlov merged commit 36607da into aio-libs:master Sep 29, 2018
@asvetlov
Copy link
Member

Thanks!

@artslob
Copy link
Contributor Author

artslob commented Sep 29, 2018

it should land on aiohttp 3.5 only

@asvetlov
Maybe change current documentation for aiohttp.request: remove note about this parameter?
And add it later on 3.5?

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR enhancement outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants