Not work with url with ':'

[pnvasko]

Hi,

get trouble with use aiohttp:
http://www.homeaway.com/search/refined/world/region:1/Leisure+Activities:golf
don't give correct answer. urllib.request work correct

regards,
V

[popravich]

Hi @pnvasko,
Can you be more specific? How exactly aiohttp does not provide correct answer?
I've just tried and got 200 ok with body about 30Kb.

[pnvasko]

Change target url. For sample ask - http://www.homeaway.com/search/refined/world/region:1/Leisure+Activities:golf, get content like this page http://www.homeaway.com/search

[popravich]

ok, I see.
Actually the problem is with + it gets quoted into %2B

[pnvasko]

What can I do ?

понедельник, 31 августа 2015 г. пользователь Alexey Popravka написал:

ok, I see.
Actually the problem is with + it gets quoted into %2B

—
Reply to this email directly or view it on GitHub
#480 (comment).

[popravich]

@fafhrd91, @asvetlov guys!
The problem is here aiohttp/client_reqrep.py:178
I've 'blamed' that line to the very begining (f382b5f)
and I could not see why path should be re-quoted.
The urlsplit returns path as is, so if it was already quoted it gets double-quoted.
And it also leads to re-quoting of location header in redirects.

I think we should remove this quoting of path and leave it up to end-users.
What do you think?

[asvetlov]

I think we should make trivial one-page app displaying request.raw_path then open the page in browser and play with different characters in path string.

Reference to standard is also good but I like to see what does Chrome and Firefox in case of suspicious symbols

[asvetlov]

I've made a PR for the issue: #484

URL requoting is borrowed from requests library, I've checked it in Chrome and Firefox also.

[pnvasko]

Thank you!

2015-09-01 21:48 GMT+07:00 Andrew Svetlov notifications@github.com:

I've made a PR for the issue: #480
#480

URL requoting is borrowed from requests library, I've checked it in Chrome
and Firefox also.

—
Reply to this email directly or view it on GitHub
#480 (comment).

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.