Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate bare request(), get() and family for encouraging ClientSession usage #729

Closed
asvetlov opened this issue Jan 10, 2016 · 4 comments
Closed

Deprecate bare request(), get() and family for encouraging ClientSession usage #729

asvetlov opened this issue Jan 10, 2016 · 4 comments
Labels
outdated
Milestone
0.21

Comments

@asvetlov
Copy link
Member

Recreating Connector on every request is a little expensive.
ClientSession allows connection utilization, it also supports keep-alives out-of-the box.

Unfortunately I see many examples of bare coroutines usage -- people are lazy :(
@gwillem
Copy link
Contributor

gwillem commented Jan 10, 2016

Hi Andrew! IMHO most people will follow the basic examples without reading everything. Upper half of http://aiohttp.readthedocs.org/en/stable/client.html does not mention connectors.

Then again, people who care for performance are probably also the ones who do read the reference doc.

@asvetlov
Copy link
Member Author

Would you update docs to emphasize ClientSession usage?

@asvetlov asvetlov added this to the 0.21 milestone Jan 13, 2016
@asvetlov
Copy link
Member Author

Fixed by e194ede and e8b47f7

@Hornwitser Hornwitser mentioned this issue Feb 11, 2016
Closed
freiheit added a commit to freiheit/discord_feedbot that referenced this issue Feb 21, 2016
@freiheit
Change from aiohttp.get to aiohttp.ClientSession. (see aio-libs/aioht…
993b895 
…tp#729 and Rapptz/discord.py#99)
@Artimi Artimi mentioned this issue Apr 24, 2017
Closed
@Fr6jDJF Fr6jDJF mentioned this issue Dec 4, 2017
Merged
skeith added a commit to skeith/tmerc-cogs that referenced this issue Dec 6, 2017
@skeith
Let's stop being deprecated
19f6001 
aio-libs/aiohttp#729
@skeith skeith mentioned this issue Dec 6, 2017
Closed
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
0.21
Development

No branches or pull requests
2 participants
@asvetlov @gwillem