Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test suite #98

Closed
asvetlov opened this issue Jun 20, 2017 · 2 comments · Fixed by #915
Closed

Refactor test suite #98

asvetlov opened this issue Jun 20, 2017 · 2 comments · Fixed by #915

Comments

@asvetlov
Copy link
Member

asvetlov commented Jun 20, 2017

Now dependency tree for test_multidict.py is too complicated ever for me.
We need to slip it into several files, rewrite tests in pytest style and reduce test class dependencies.

Like:

READONLY_DICTS = [MultiDict, CIMultiDict, MultiDictProxy, CIMultiDictProxy]  # plus pure python classes

@pytest.parametrize(READONLY_DICTS)
def test_something(dct):
    pass
@webknjaz
Copy link
Member

webknjaz commented Oct 1, 2017

I'd add:

  • eliminate use of pure unittest (inheriting from TestCase blocks using some of pytest features)
  • move fixtures, which are copy-pasted across test modules to conftest.py

@webknjaz
Copy link
Member

I believe this is fully addressed with #915 and 7513e6a.

@webknjaz webknjaz linked a pull request Jan 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants