Remove unittest (was: Refactor test suite) #161
Conversation
* quite a few cases have been lost along the way, find out where!
tests/test_multidict.py
Outdated
| self.assertEqual( | ||
| str(d), | ||
| assert( | ||
| str(d) == | ||
| "<%s('key': 'one', 'key': 'two')>" % cls.__name__) |
There was a problem hiding this comment.
You'd better do expected = "<%s('key': 'one', 'key': 'two')>" % cls.__name__ one line above instead of having multiline expression for the sake of readability
tests/test_multidict.py
Outdated
|
|
||
| def test_eq(self): | ||
| d1 = self.make_dict(Key='val') | ||
| d2 = self.make_dict(KEY='val') | ||
|
|
||
| self.assertEqual(d1, d2) | ||
| assert d1 == d2 | ||
|
|
||
|
|
||
| class TestPyMultiDictProxy(_TestProxy, unittest.TestCase): |
There was a problem hiding this comment.
You'll need to eliminate unittest.TestCase here as well ;)
|
@igneus thanks for taking this task! We'll be waiting for the completed version :) |
tests/test_multidict.py
Outdated
| [('key', 'one'), ('key', 'two'), ('key', 3)]) | ||
| expected = [('key', 'one'), ('key', 'two'), ('key', 3)] | ||
| assert list(d.items()) == expected | ||
| assert list(d.items()) == expected # was the repetition intentional? |
tests/test_multidict.py
Outdated
| [('key', 'one'), ('key', 'two'), ('key', 3)]) | ||
| expected = [('key', 'one'), ('key', 'two'), ('key', 3)] | ||
| assert list(d.items()) == expected | ||
| assert list(d.items()) == expected # was the repetition intentional? |
|
Unittest is gone. Should I continue the "more serious" test refactoring in this PR, or do you prefer to review and merge this step before going on? |
|
@igneus it is much easier to keep track of small changes. I'd be glad to merge this one after review and proceed with separate PR |
igneus
changed the title
igneus
changed the title
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 329 329
=====================================
Hits 329 329Continue to review full report at Codecov.
|
tests/test_multidict.py
Outdated
| [('key', 'one'), ('key', 'two'), ('key', 3)]) | ||
| expected = [('key', 'one'), ('key', 'two'), ('key', 3)] | ||
| assert list(d.items()) == expected | ||
| assert list(d.items()) == expected # was the repetition intentional? |
There was a problem hiding this comment.
Honestly I don't remember.
You could consider it as a test for stable items order but better to have a separate test for the case.
Let's just remove the line.
it's stuck for hours (and it's not the first time this issue appears) @asvetlov can we skip this check? |
|
Sure |
I've started working on #98 . I open this PR in order to allow maintainers to review continuously if they wish so.