🧪 Rewire pytest fixtures avoiding import loops #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
webknjaz
force-pushed
the
bugfixes/tests-import-loop
branch
9 times, most recently
from
4f58a19
to
f5989b3
Compare
webknjaz
force-pushed
the
bugfixes/tests-import-loop
branch
6 times, most recently
from
aa8c76d
to
fa62492
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #915 +/- ##
===========================================
+ Coverage 76.19% 88.88% +12.69%
===========================================
Files 5 5
Lines 504 504
Branches 116 116
===========================================
+ Hits 384 448 +64
+ Misses 118 34 -84
- Partials 2 22 +20 ☔ View full report in Codecov by Sentry. |
webknjaz
force-pushed
the
bugfixes/tests-import-loop
branch
from
fa62492
to
5052cd8
Compare
webknjaz
force-pushed
the
bugfixes/tests-import-loop
branch
6 times, most recently
from
b0c5b45
to
7451dce
Compare
This patch also refactors and reduces the duplication of the previously existing fixtures for retrieving different multidict module implementations and makes the c-extension testing controllable by a CLI option on the pytest level. Fixes aio-libs#837
webknjaz
force-pushed
the
bugfixes/tests-import-loop
branch
from
7451dce
to
fc739fa
Compare
webknjaz
added a commit
to webknjaz/multidict
that referenced
this pull request
Jan 14, 2024
psf-chronographer
bot
added
the
bot:chronographer:provided
webknjaz
force-pushed
the
bugfixes/tests-import-loop
branch
from
09def78
to
548523e
Compare
Closed
webknjaz
added a commit
that referenced
this pull request
Jan 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch also refactors and reduces the duplication of the previously existing fixtures for retrieving different multidict module implementations and makes the c-extension testing controllable by a CLI option on the pytest level.
Fixes #837
Are there changes in behavior for the user?
The contributors will have a better control over what to test. And there shouldn't be import loops preventing the testing of C extensions in some cases.
Checklist