Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MultiDict.items().isdisjoint() for C Extensions #927

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

Jamim
Copy link
Contributor

@Jamim Jamim commented Jan 19, 2024

Hello @webknjaz,

What do these changes do?

These changes fix a mismatch at views.h that causes SystemError: null argument to internal routine when calling MultiDict.items().isdisjoint().

Are there changes in behavior for the user?

MultiDict.items().isdisjoint() will not cause a SystemError when using C Extensions.

Related issue number

Semi-related issue:

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

Best regards!

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68b080e) 96.53% compared to head (cb98d47) 96.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
+ Coverage   96.53%   96.74%   +0.20%     
==========================================
  Files          19       19              
  Lines        1964     1965       +1     
  Branches      188      188              
==========================================
+ Hits         1896     1901       +5     
+ Misses         44       40       -4     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@webknjaz webknjaz changed the title Fix MultiDict.items().isdisjoint() for C Extensions Fix MultiDict.items().isdisjoint() for C Extensions Jan 20, 2024
@webknjaz webknjaz merged commit 82b559c into aio-libs:master Jan 20, 2024
49 of 51 checks passed
@Jamim Jamim deleted the fix/c-itemsview-isdisjoint branch January 20, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants