Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n get_locale without User #546

Merged
merged 6 commits into from
Apr 27, 2021
Merged

i18n get_locale without User #546

merged 6 commits into from
Apr 27, 2021

Conversation

Olegt0rr
Copy link
Contributor

Description

Fixes #544

Type of change

  • [х] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Test A
  • Test B

Test Configuration:

  • Operating System:
  • Python version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Olegt0rr Olegt0rr requested a review from a team March 27, 2021 10:12
@Olegt0rr Olegt0rr added the bug Something is wrong with the framework label Mar 27, 2021
@Olegt0rr Olegt0rr added this to the 2.12.2 milestone Mar 27, 2021
uwinx
uwinx suggested changes Mar 30, 2021
View reviewed changes
aiogram/contrib/middlewares/i18n.py Outdated Show resolved Hide resolved
@Olegt0rr Olegt0rr requested a review from uwinx March 30, 2021 20:22
uwinx
uwinx suggested changes Mar 31, 2021
View reviewed changes
aiogram/contrib/middlewares/i18n.py Outdated Show resolved Hide resolved
@Olegt0rr Olegt0rr requested a review from uwinx March 31, 2021 10:59
@aiogram aiogram deleted a comment from uwinx Apr 3, 2021
@Olegt0rr Olegt0rr requested review from a team and uwinx and removed request for uwinx April 4, 2021 08:58
@evgfilim1 evgfilim1 modified the milestones: 2.12.2, 2.13 Apr 26, 2021
@JrooTJunior JrooTJunior merged commit ba095f0 into dev-2.x Apr 27, 2021
@JrooTJunior JrooTJunior deleted the bug/#544-locale-without-user branch May 12, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JrooTJunior JrooTJunior JrooTJunior approved these changes

@uwinx uwinx Awaiting requested review from uwinx

Assignees
No one assigned
Labels
bug Something is wrong with the framework
Projects
None yet
Milestone
2.13
Development

Successfully merging this pull request may close these issues.

I18nMiddleware.get_user_locale() cant get user for some actions (Poll closing)
4 participants
@Olegt0rr @JrooTJunior @uwinx @evgfilim1