Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with ruby 1.8.7 #206

Closed
amit opened this issue Feb 11, 2013 · 3 comments
Closed

Error with ruby 1.8.7 #206

amit opened this issue Feb 11, 2013 · 3 comments
Assignees
Milestone

Comments

@amit
Copy link

amit commented Feb 11, 2013

Function changes_for_paper_trail uses keep_if which only works on ruby 1.9.2 onwards!

This is fixed by adding backports gem to bring in these changes to 1.8.X, but should probably be fixed in this gem.

--Amit

@ghost ghost assigned batter Feb 11, 2013
@batter batter closed this as completed in 588af56 Feb 11, 2013
@batter
Copy link
Collaborator

batter commented Feb 12, 2013

51b450a was the commit that actually addressed this issue.

@amit
Copy link
Author

amit commented Feb 12, 2013

Hmmm, I just applied 588af56
Do I need 51b450a as well ?

Thanks!
Amit

On Tue, Feb 12, 2013 at 8:34 AM, Ben Atkins notifications@git.luolix.topwrote:

51b450a 51b450a was the
commit that actually addressed this issue.


Reply to this email directly or view it on GitHubhttps://github.com//issues/206#issuecomment-13441369.

@batter
Copy link
Collaborator

batter commented Feb 12, 2013

Yes. 51b450a actually fixed it. Hash#select works differently in 1.8.7 than Hash#select in 1.9, so 588af56 actually returned an Array instead of a Hash in 1.8.7, which caused errors. Please use 51b450a.

Thanks for the error report. I wasn't aware of all these differences in behavior in the way these methods worked in different versions of Ruby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants