[hotfix] csv and json link are off (#592)

* Fixing bugs * [hotfix] csv and json link are off
apache · Jun 10, 2016 · c35e0e8 · c35e0e8
1 parent 60ed3e4
commit c35e0e8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/caravel/views.py b/caravel/views.py
@@ -728,11 +728,10 @@ def explore(self, datasource_type, datasource_id):
                 mimetype="application/json")
             return resp
         elif request.args.get("csv") == "true":
-            status = 200
             payload = obj.get_csv()
             return Response(
                 payload,
-                status=status,
+                status=200,
                 headers=generate_download_headers("csv"),
                 mimetype="application/csv")
         else:

diff --git a/caravel/viz.py b/caravel/viz.py
@@ -80,11 +80,9 @@ def __init__(self, datasource, form_data, slice_=None):
         defaults.update(data)
         self.form_data = defaults
         self.query = ""
-
         self.form_data['previous_viz_type'] = self.viz_type
         self.token = self.form_data.get(
             'token', 'token_' + uuid.uuid4().hex[:8])
-
         self.metrics = self.form_data.get('metrics') or []
         self.groupby = self.form_data.get('groupby') or []
         self.reassignments()
@@ -105,7 +103,7 @@ def reassignments(self):
 
     def get_url(self, **kwargs):
         """Returns the URL for the viz"""
-        d = self.orig_form_data.copy()
+        d = self.form_data.copy()
         if 'json' in d:
             del d['json']
         if 'action' in d: