-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shipping with CSS templates out of the box #163
Conversation
.widget.pivot_table td,th { | ||
padding: 1px 5px; | ||
font-size: small; | ||
.table tr>th { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's generally really bad to use the !important
flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how else to compete with the very high selectivity css in the bootstrap/dataTables css...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that can be tricky sometimes, okay.
@mistercrunch this seems okay overall to me, but how are you thinking about this in relation to the overall bootstrap theme? Seems like we can ship that for devs that want to customize bootstrap vars, and use this as an easier interface for updating styles int he browser itself? also what library is used to check the .css syntax in the modal? it was making suggestions for me like "this rule is too specific" that were actually wrong! |
Oh, so the wrong suggestion would be coming from The theming is to allow people to customize the look and feel of individual dashboards by applying templates and modifying them. That css lives on top of the bootstrap theme and only affects individual dashboards. Live updating is a cool feature I think that makes iterating on designs quick. |
👍 |
Shipping with CSS templates out of the box
@williaster
Also the modal becomes opacity 50% while editing css and moving the mouse out of the modal.