Adding favorites for Slices and Dashboards #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
favstar
branch
2 times, most recently
from
6aba836
to
8a7a214
Compare
|
|
|
|
|
|
|
Coverage decreased (-0.3%) to 65.325% when pulling 8a7a214570048daf5510b545f81550c1bc8bfb33 on favstar into b0f10a9 on master. |
|
Coverage decreased (-0.3%) to 65.325% when pulling 8a7a214570048daf5510b545f81550c1bc8bfb33 on favstar into b0f10a9 on master. |
|
Coverage decreased (-0.3%) to 65.325% when pulling 8a7a214570048daf5510b545f81550c1bc8bfb33 on favstar into b0f10a9 on master. |
|
|
|
Coverage decreased (-0.3%) to 65.325% when pulling ae98bb154bf8f3cf3db3fbc0b9c3700220137d2f on favstar into 9d3bf77 on master. |
|
|
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
…he#194) When the page is served over an insecure connection, some browsers (Firefox) will disable the CacheStorage API for security reasons and will throw an error when an attempt is made to use it. Thus, do not even attempt to use CacheStorage on such connections in the first place. fix apache#193
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…he#194) When the page is served over an insecure connection, some browsers (Firefox) will disable the CacheStorage API for security reasons and will throw an error when an attempt is made to use it. Thus, do not even attempt to use CacheStorage on such connections in the first place. fix apache#193
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…he#194) When the page is served over an insecure connection, some browsers (Firefox) will disable the CacheStorage API for security reasons and will throw an error when an attempt is made to use it. Thus, do not even attempt to use CacheStorage on such connections in the first place. fix apache#193
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…he#194) When the page is served over an insecure connection, some browsers (Firefox) will disable the CacheStorage API for security reasons and will throw an error when an attempt is made to use it. Thus, do not even attempt to use CacheStorage on such connections in the first place. fix apache#193
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…he#194) When the page is served over an insecure connection, some browsers (Firefox) will disable the CacheStorage API for security reasons and will throw an error when an attempt is made to use it. Thus, do not even attempt to use CacheStorage on such connections in the first place. fix apache#193
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@williaster @michellethomas