Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A welcome page #198

Merged
merged 2 commits into from
Mar 26, 2016
Merged

A welcome page #198

merged 2 commits into from
Mar 26, 2016

Conversation

mistercrunch
Copy link
Member

It should grow into having more controls, but this looks pretty good already.
screen shot 2016-03-25 at 6 09 52 pm

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.07% when pulling c920355 on welcome into 10a1edd on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 65.368% when pulling c920355 on welcome into 10a1edd on master.


require('bootstrap');
require('datatables');
require('d3');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this export a global d3 var for the calendar? i.e., does it not need to be var d3 = require('d3');? or maybe it's not necessary if calendar has it's own d3 ref?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to work after removing both dash.js (which I don't need) and d3... I'll keep it off then

@williaster
Copy link
Contributor

couple nit things but overall looks good :)

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 8c0870e on airbnb:welcome into 10a1edd on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 65.368% when pulling 8c0870e on welcome into 10a1edd on master.

@mistercrunch
Copy link
Member Author

Fixed everything, merging!

@mistercrunch mistercrunch merged commit 1c19f7f into master Mar 26, 2016
@mistercrunch mistercrunch deleted the welcome branch March 26, 2016 05:15
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.5 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants