Viz type #37
Merged
Viz type #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW I pushed to master a fix for the |
| @@ -248,6 +252,7 @@ def get_json_data(self): | |||
|
|
|||
|
|
|||
| class NVD3Viz(BaseViz): | |||
| viz_type = None | |||
| verbose_name = "Base NVD3 Viz" | |||
| template = 'panoramix/viz_nvd3.html' | |||
| chart_kind = 'line' | |||
There was a problem hiding this comment.
Guess you can also remove this.
|
|
mistercrunch
added a commit
that referenced
this pull request
Oct 2, 2015
hughhhh
referenced
this pull request
in lyft/incubator-superset
Apr 1, 2018
Make sure upstream folder is cloned properly NOT PASSING TESTS
This was referenced Aug 27, 2020
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
BREAKING CHANGE: Change Registry constructor API to take object instead of single string name. feat: Add overwritePolicy for Registry so developer can customize whether overwriting is ALLOW, WARN or PROHIBIT.
zhaoyongjie
pushed a commit
that referenced
this pull request
Nov 24, 2021
BREAKING CHANGE: Change Registry constructor API to take object instead of single string name. feat: Add overwritePolicy for Registry so developer can customize whether overwriting is ALLOW, WARN or PROHIBIT.
zhaoyongjie
pushed a commit
that referenced
this pull request
Nov 24, 2021
* fix: change references to vega-lite that broke build * refactor: rename fielddef to channeldef
zhaoyongjie
pushed a commit
that referenced
this pull request
Nov 25, 2021
BREAKING CHANGE: Change Registry constructor API to take object instead of single string name. feat: Add overwritePolicy for Registry so developer can customize whether overwriting is ALLOW, WARN or PROHIBIT.
zhaoyongjie
pushed a commit
that referenced
this pull request
Nov 25, 2021
* fix: change references to vega-lite that broke build * refactor: rename fielddef to channeldef
zhaoyongjie
pushed a commit
that referenced
this pull request
Nov 26, 2021
BREAKING CHANGE: Change Registry constructor API to take object instead of single string name. feat: Add overwritePolicy for Registry so developer can customize whether overwriting is ALLOW, WARN or PROHIBIT.
zhaoyongjie
pushed a commit
that referenced
this pull request
Nov 26, 2021
* fix: change references to vega-lite that broke build * refactor: rename fielddef to channeldef
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@akuhn, a few changes we spoke about and a bugfix