Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an npmignore file to all packages #1204

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

lelandrichardson
Copy link
Collaborator

Adds an npmignore file to all of the packages since the root one does not apply to npm publishing anymore

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to symlink the root one instead, rather than having duplicate copies that can get out of sync?

@lelandrichardson
Copy link
Collaborator Author

@ljharb i considered this, but thought that they might need to diverge over time. Thoughts?

@ljharb
Copy link
Member

ljharb commented Sep 30, 2017

That's fair; but it'd be easy to copy it when a need arose. Not a huge deal either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants