Clarify dev workflow in CONTRIBUTING.md #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jack-lewin
commented
Oct 1, 2017
jack-lewin
commented
- Explains that the test suite & linter run on built Enzyme
- Adds guidance on dev workflow (as per recommendation in Add better dev/test instructions in CONTRIBUTING.md #1173)
Explain that the test suite & linter run on built Enzyme; Add guidance on dev workflow
ljharb
approved these changes
Oct 2, 2017
CONTRIBUTING.md
Outdated
| @@ -62,10 +74,15 @@ npm run test:watch | |||
| This codebase adheres to the [Airbnb Styleguide](https://github.com/airbnb/javascript) and is | |||
| enforced using [ESLint](http://eslint.org/). | |||
|
|
|||
| As with the test suite, linting rules apply to *built* Enzyme. | |||
There was a problem hiding this comment.
This is maybe only partially correct. I believe the import/* eslint rules rely on built enzyme because they actually look at the filesystem and require that the built files be there, but linting doesn't actually run on the built files, they run on the src files... but they require the built files to be there. Kind of annoying that it works that way but hey, this is the babel-compiled world we live in...
There was a problem hiding this comment.
Good point - I've added some clarification to that.
This was referenced Aug 8, 2018
This was referenced Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.