[bugfix] nodeHasId has issue with 0.14 in some cases #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
lelandrichardson
added a commit
that referenced
this pull request
Dec 10, 2015
[bugfix] nodeHasId has issue with 0.14 in some cases
This was referenced Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @ljharb @goatslacker
The spec that was added in this PR would succeed in React 0.13 but fail in React 0.14 due to some changes in behavior from the two. This had been abstracted away for some selectors (like class name) through the correct
propsOfNode(node)function, but thenodeHasIdfunction was still prone to these issues.Thanks to @clouddra for pointing out.
Fixes #64