Is it a good practice to get current list inside PagingEpoxyController

[pcqpcq]

I found nothing like getCurrentData() in PagingEpoxyController, so I create one like this:

public class MyController extends PagingEpoxyController<Foo> {

    // ...other stuff

    private PagedList<Foo> currentData;

    @Override
    public void setList(@Nullable PagedList<Foo> list) {
        super.setList(list);
        this.currentData = list;
    }

    protected PagedList<Foo> getCurrentData() {
        if (this.currentData != null) {
            return this.currentData;
        }
        return (PagedList<Foo>) Collections.<Foo>emptyList();
    }

}

with Placeholders disabled:

new PagedList.Config.Builder()
        .setPageSize(10)
        .setPrefetchDistance(50)
        .setEnablePlaceholders(false)
        .build())

On the other hand, there is getCurrentList() in PagedListAdapter

    @Nullable
    public PagedList<T> getCurrentList() {
        return this.mHelper.getCurrentList();
    }

And, before I make a pr:
Why there is nothing like this in PagingEpoxyController?
Is it a bad practice for PagingEpoxyController?

[elihart]

I don't think this is bad practice, I just didn't consider it. Seems valid, thanks for the idea!

One concern, since both a List and PagedList can be set, which should be returned? There could be a separate method for each.

[elihart]

There could be getPagedList which returns the current list or null, and then getCurrentList which returns the current data being displayed - either the current paged list snapshot or the java list that was set ( or empty list if nothing is set). What do you think?

[pcqpcq]

It's very nice, I've make a pr here: #317

[pcqpcq]

closed as #317 being merged.