Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel SnapHelperFactory #355

Closed
jo8558 opened this issue Dec 9, 2017 · 2 comments
Closed

Carousel SnapHelperFactory #355

jo8558 opened this issue Dec 9, 2017 · 2 comments

Comments

@jo8558
Copy link

jo8558 commented Dec 9, 2017

It is not able to implement a CustomSnapHelperFactory because it is not able to override the buildSnapHelper method.
Another issue: It is not possible to call the method Carousel.setDefaultGlobalSnapHelperFactory(...). Only Carousel.setDefaultItemSpacingDp(...) is available.
@elihart
Copy link
Contributor

elihart commented Dec 10, 2017

Sorry about that, my mistake. This should fix it I believe - #356

Thanks for reporting!

@jo8558
Copy link
Author

jo8558 commented Dec 10, 2017

Thanks for the instant reply. I thought that this issue was only due to visibility issue

@elihart elihart closed this as completed Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elihart @jo8558