Prepare to switch to eslint-plugin-react 6 #975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akozhemiakin
force-pushed
the
fix-react-rule
branch
from
572ebe1 to
6678473
Compare
from "no-deprecated" must be removed because they were deprecated in eslint-plugin-react since version 5.* and removed in 6.0.0-rc.0. Also it is already specified in the shared section (settings.react.pragma) as it should be, so nothing to fix there. "allow-in-func" parameter must be removed from "no-did-mount-set-state" and "no-did-update-set-state" because since 6.0.0-rc.0 it is the default behavior and "allow-in-func" parameter was removed. "wrap-multilnes" was deprecated and "jsx-wrap-multilines" must be used instead.
akozhemiakin
force-pushed
the
fix-react-rule
branch
from
6678473 to
6542d2d
Compare
akozhemiakin
changed the title
|
Thanks for the contribution, but I already have all the changes required to switch to eslint-plugin-react v6 locally. I do not want to switch to an rc version prior to v6 being released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is applicable to eslint-plugin-react@^6.0.0-rc.0. So I think it will be a good idea
to keep it until switching to that version and update it along with new breaking changes in react plugin.
"pragma" parameter from "jsx-uses-react" and "react" parameter from "no-deprecated" must be removed because they were deprecated in eslint-plugin-react since version 5.* and removed in 6.0.0-rc.0. Also it is already specified in the shared section (settings.react.pragma) as it should be, so nothing to fix there.
"allow-in-func" parameter must be removed from "no-did-mount-set-state" and "no-did-update-set-state" because since 6.0.0-rc.0 it is the default behavior and "allow-in-func" parameter was removed.
"wrap-multilnes" was deprecated and "jsx-wrap-multilines" must be used instead.