-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaks webpack: 'return' outside of function #12
Comments
This seems to be a problem with the promise.allsettled package. It looks like you already opened an issue over there: es-shims/Promise.allSettled#7 cc @ljharb |
Top level return has always been valid in node modules; this seems to be a problem with a webpack configuration. |
ljharb
added a commit
to inspect-js/is-map
that referenced
this issue
Dec 17, 2019
Closes #5. Closes #4. Closes #3. Closes inspect-js/node-deep-equal#78. Closes es-shims/Promise.allSettled#7. Closes airbnb/js-shims#12. Relates to inspect-js/is-set#4, inspect-js/is-set#5 Addresses storybookjs/storybook#9154.
ljharb
added a commit
to gitim/is-set
that referenced
this issue
Dec 17, 2019
Closes inspect-js#5. Closes inspect-js#4. Closes inspect-js#3. Closes inspect-js/node-deep-equal#78. Closes es-shims/Promise.allSettled#7. Closes airbnb/js-shims#12. Relates to inspect-js/is-map#3, inspect-js/is-map#4, inspect-js/is-map#5 Addresses storybookjs/storybook#9154.
v2.0.1 of both is-map and is-set have been released. |
ljharb
added a commit
to inspect-js/is-weakmap
that referenced
this issue
Dec 18, 2019
Closes inspect-js/node-deep-equal#79. Closes inspect-js/node-deep-equal#78. Closes es-shims/Promise.allSettled#7. Closes airbnb/js-shims#12. Relates to: - inspect-js/is-map#5 - inspect-js/is-map#4 - inspect-js/is-map#3 - inspect-js/is-set#5 - inspect-js/is-set#4 - storybookjs/storybook#9154.
ljharb
added a commit
to inspect-js/is-weakset
that referenced
this issue
Dec 18, 2019
Closes inspect-js/node-deep-equal#79. Closes inspect-js/node-deep-equal#78. Closes es-shims/Promise.allSettled#7. Closes airbnb/js-shims#12. Relates to: - inspect-js/is-map#5 - inspect-js/is-map#4 - inspect-js/is-map#3 - inspect-js/is-set#5 - inspect-js/is-set#4 - storybookjs/storybook#9154.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This package depends on "promise.allsettled": "^1.0.0",
works when forced to
1.0.1
, but when resolved to1.0.2
breaks webpack builds with:The text was updated successfully, but these errors were encountered: