LottieLogger.assertionFailure/Swift.assertionFailure Crash when asset is not found in bundle.

[rfigini]

Which Version of Lottie are you using?

Lottie 3.4.1

Expected Behavior

Not crash when execute AnimationImageProvider.imageForAsset and not found the asset in bundle.

Actual Behavior

Crash when execute AnimationImageProvider.imageForAsset and not found the asset in bundle.

I guess the library wants to log an exception but it crashes, this doesn't happen at ver. 3.3.0
Could you help me?
Thanks !

[calda]

Swift.assertionFailure crashes in debug builds but is a no-op in production builds, so this wouldn't happen in production.

If you prefer not to fix the underlying issue where Lottie cannot find the image in your animation json file, you can customize the LottieLogger.shared.assertionFailure method to not call Swift.assertionFailure. For example you can do:

// Early in your app lifecycle, like in your AppDelegate:
LottieLogger.shared = .printToConsole // print warnings to console instead of calling Swift.assertionFailure

[rfigini]

In our case, we don't have an image at that moment, because we replace it programatically. That's why "img_1.png" is not found, it's a dummy image name. Can We do something else in this case?

[calda]

Ok, that use case makes sense to me -- it seems like we should probably use LottieLogger.shared.warn instead of LottieLogger.shared.assertionFailure here. Would you be interested in making a pull request with that change?

[rfigini]

Yes for sure, I'll send you the pull request with this change adding a reference to this discussion in the description.

[rfigini]

Here's the PR, thanks for your help.

[calda]

Thanks!