-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redundant conformance of 'Color' #1420
Comments
It's not just For now I've worked around this issue by adding this to my project:
and I keep having to add to this list as I build out my app's infrastructure. Despite this, I've also had to explicitly use the SwiftUI namespace in some files, like so
But this should not be necessary. A longstanding best practice for libraries is to "namespace" their custom objects by prepending them with a custom identifier, usually the library or author's initials. So, for example, lottie-ios As SwiftUI gains adoption in more complex production apps, these name conflicts will become more of a problem, and will increasingly be a barrier to adopting this library and Lottie in general. Please consider renaming all your public primitives. |
Renaming these public types would be a breaking API change, so we would need to do it in a Lottie 4.0.0 release. I started a discussion about this here: #1713 |
Do |
Any new progress on this issue? |
@erwinmaza We're renaming If this is causing a problem we'd like to also fix it in Lottie 4.0, which we are releasing in a few weeks. |
I'm incorporating the library as source code in my project (I prefer full source control and stability, plus I've customized it a bit), so As an aside, I moved from the Great to hear that 4.0 is coming out soon. I've had "Update Lottie to 3.4.0" for the performance improvements in my backlog for awhile. Now I'll just wait for 4.0 so I don't have to rename things again. Thanks for addressing this issue. |
I see, thanks for the info -- I think I'm going to leave them as-is for now. Since those types are internal we can rename them in the future without breaking source compatibility, we don't need to make that change specifically in Lottie 4.0. |
We made the first step towards resolving this issue in Lottie 3.5.0. We will fix the issue completely in Lottie 4.0. |
Hello,
I'm getting error when triyng to extend the SwiftUI.Color because of the Color struc extension.
"redundant conformance of 'Color'"
Thanks in advance!
Check these before submitting:
This issue is a:
What Platform are you on?
What Language are you in?
Expected Behavior
I expect to extend SfiwftUI.Color wihtout issues.
Actual Behavior
I'm getting the "redundant conformance of 'Color'" error because of the extension of the Color struct.
The text was updated successfully, but these errors were encountered: