Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carthage macOS use the wrong Swift Module Name (Lottie_macOS) but not (Lottie) #1638

Closed
dreampiggy opened this issue Jul 8, 2022 · 1 comment · Fixed by #1641
Closed

Carthage macOS use the wrong Swift Module Name (Lottie_macOS) but not (Lottie) #1638

dreampiggy opened this issue Jul 8, 2022 · 1 comment · Fixed by #1641

Comments

@dreampiggy
Copy link

Which Version of Lottie are you using?

Lottie 3.4.0

Expected Behavior

The PRODUCT_MODULE_NAME should be Lottie, not Lottie_macOS, which is the target name.

This will cause downstream have to use

import Lottie_macOS

instead, which is a break chanage from Lottie v3.1.0

截屏2022-07-09 01 32 44

Actual Behavior

Animation JSON
@calda calda mentioned this issue Jul 8, 2022
Merged
@calda
Copy link
Member

calda commented Jul 8, 2022

Thanks for the report! Fixed in #1641.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Carthage support on macOS airbnb/lottie-ios
2 participants
@calda @dreampiggy