Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation is not correct after updating to 4.3.x #2226

Closed
squarefrog opened this issue Nov 2, 2023 · 2 comments · Fixed by #2285
Closed

Animation is not correct after updating to 4.3.x #2226

squarefrog opened this issue Nov 2, 2023 · 2 comments · Fixed by #2285
Labels
bug Core Animation rendering engine Regressions introduced by the Core Animation rendering engine

Comments

@squarefrog
Copy link

squarefrog commented Nov 2, 2023

After updating to 4.3.0 or higher, we noticed that our startup animation handles flip transitions incorrectly. Running git bisect against the example project leads us to believe this PR introduced the issue.

We are able to work around this issue by using main thread as the rendering engine.

Which Version of Lottie are you using?

Lottie 4.3.x

Expected Behavior

In 4.2.0 we see the animation rotate the B character up, then flip then rotate down.

4 2 0 A 4 2 0 B

Actual Behavior

In 4.3.x the x position of the B character changes during the flip transition

4 3 3 A 4 3 3 B

Animation JSON

0splash_logo_animation.json

@calda calda added bug Core Animation rendering engine Regressions introduced by the Core Animation rendering engine labels Nov 2, 2023
@calda
Copy link
Member

calda commented Jan 8, 2024

Thanks for identifying the PR that introduced this regression! Fixed in #2285.

@squarefrog
Copy link
Author

This is amazing, thank you @calda !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Core Animation rendering engine Regressions introduced by the Core Animation rendering engine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants