[Tests] migrate tests to Github Actions #249
Conversation
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: ljharb/actions/node/install@main |
There was a problem hiding this comment.
I don't have much experience with GitHub Actions, but having code slurped in like this makes me a bit nervous because it is from an external source and it is not pinned to a specific version. Are these legitimate concerns here?
There was a problem hiding this comment.
Only if you don’t think you can rely on the author maintaining back compat and being a good actor. travis-ci already relies on the same things and auto-updates nvm to whatever version is published.
Happy to peg it to a sha if you prefer, it just means bugfixes or improvements have to be explicitly updated to here rather than automatically flowing in.
|
@ljharb you mentioned that 4 status checks should be made required as of this PR, but I'm not sure which 4 you are actually referring to. Can you help me out with that? |
|
Absolutely:
ah, but the other two have to land in master, and be triggered by a PR after that, before they'll show up:
so it's totally fine to just add the first two for now. (travis-ci also needs to be unchecked) |
This migrates tests to use github actions, and in so doing adds new node majors, and will automatically add new ones as they're released.
(see ljharb/object.assign#81)
In order for this to land, branch protections must be updated to uncheck travis, and to check the 4 overarching actions status checks that this PR should generate.