add option for pulling favourited dashboards by username (#2661)

* add option for pulling favourited dashboards by username

add tests

* fix too many lines pep8 error

superset/views/core.py

@@ -1399,6 +1399,14 @@ def csrf_token(self):
             mimetype='text/json',
         )
 
+    @api
+    @has_access_api
+    @expose("/fave_dashboards_by_username/<username>/", methods=['GET'])
+    def fave_dashboards_by_username(self, username):
+        """This lets us use a user's username to pull favourite dashboards"""
+        user = sm.find_user(username=username)
+        return self.fave_dashboards(user.get_id())
+
     @api
     @has_access_api
     @expose("/fave_dashboards/<user_id>/", methods=['GET'])

tests/core_tests.py

@@ -609,8 +609,8 @@ def test_fetch_datasource_metadata(self):
         for k in keys:
             self.assertIn(k, resp.keys())
 
-    def test_user_profile(self):
-        self.login(username='admin')
+    def test_user_profile(self, username='admin'):
+        self.login(username=username)
         slc = self.get_slice("Girls", db.session)
 
         # Setting some faves
@@ -641,6 +641,8 @@ def test_user_profile(self):
         self.assertNotIn('message', data)
         data = self.get_json_resp('/superset/fave_dashboards/{}/'.format(userid))
         self.assertNotIn('message', data)
+        data = self.get_json_resp('/superset/fave_dashboards_by_username/{}/'.format(username))
+        self.assertNotIn('message', data)
 
 
 if __name__ == '__main__':