You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@visx/scale depends on d3-scale@^3.0.1 and @types/d3-scale@^2.1.1. This means that a v3 scale passed to @visx/axis won't type-check correctly even though the runtime version is v3. It should depend on @types/d3-scale@^3.0.0 instead.
side q: are you thinking of using visx for mixcreant? I've done some tinkering / thinking about cocktail vis so am excited to see what that turns out to be 📈 🍹 👀
Yes, this makes sense.
The library @types/d3-scale@3.x was just released 2 days ago.
There should not be breaking changes for the existing scales as d3-scale upgrade from 2 to 3 only drop support for older browser and IE. There are a few new features for color scales, which should not affect scales used with axis.
I have to verify a what else were changed in the type declaration v3 too as there were some mismatches between d3-scale@2 behaviors and the type declaration v2. Hopefully they got fixed in this new v3.
@visx/scale
depends ond3-scale@^3.0.1
and@types/d3-scale@^2.1.1
. This means that a v3 scale passed to@visx/axis
won't type-check correctly even though the runtime version is v3. It should depend on@types/d3-scale@^3.0.0
instead.visx/packages/visx-scale/package.json
Lines 33 to 38 in c0eb0b2
The text was updated successfully, but these errors were encountered: